Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move merkle proofs code from nimbus-eth2 and salvage what is useful from nim-eth #4

Closed
kdeme opened this issue Oct 22, 2021 · 2 comments
Closed

Move merkle proofs code from nimbus-eth2 and salvage what is useful from nim-eth #4

kdeme opened this issue Oct 22, 2021 · 2 comments

Comments

@kdeme
Copy link
Collaborator

kdeme commented Oct 22, 2021

Work done in status-im/nimbus-eth2#2980 is part of the ssz merkle proofs specification and could perfectly be moved also into this repository.

Should also check if anything should be taken from work that was started here in nim-eth: status-im/nim-eth#379
Perhaps some tests?

Also not sure where this should go: status-im/nim-eth#381
@kdeme kdeme mentioned this issue Nov 10, 2021
Closed
@kdeme
Copy link
Collaborator Author

kdeme commented Dec 10, 2021

Code in nim-eth got removed here: status-im/nim-eth#447

For this item to be fulfilled I believe the build_proof code and the is_valid_merkle_branch in nimbus-eth2 needs to be moved to this repo.

@kdeme
Copy link
Collaborator Author

kdeme commented May 18, 2022

Closing this as it was done in #19

@kdeme kdeme closed this as completed May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kdeme