[5.x] Query Scopes config option: show available query scopes in dropdown #9933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duncanmcclean
changed the title
…-scopes-config-options
duncanmcclean
changed the title
jasonvarga
requested changes
May 14, 2024
Should be fixed now 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes a small improvement to the "Query Scopes" config option on some of our fieldtypes.
Previously, when you clicked into the config option's input, a dropdown would appear. However, it'd never actually show any dropdown options.
This could be confusing for some developers - leading to them thinking they did something wrong when creating the query scope, causing it to not appear. But in fact, it was just showing no options because we hadn't hooked up any options to it.
This PR adds all of the available query scopes as dropdown options. It also makes the relevant changes to the Taggable fieldtype to allow for options to be passed in.