New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Make `tearDown` method protected on `AddonTestCase` #9924

Merged

jasonvarga merged 1 commit into master from make-teardown-method-protected-on-addontestcase

Apr 18, 2024

Member

duncanmcclean commented Apr 18, 2024

This pull request makes the tearDown method on our new AddonTestCase class protected instead of public.

In my testing, tearDown being public was causing issues for addons with Pest test suites. The setUp method is already protected.


          Make tearDown method protected on AddonTestCase

e9dbf8d

jasonvarga merged commit ff52ed0 into master

32 checks passed

jasonvarga deleted the make-teardown-method-protected-on-addontestcase branch

April 18, 2024 16:07

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet