New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Dictionary Fixes #10719

Merged

jackmcdade merged 2 commits into 5.x from dictionary-fixes

Aug 30, 2024

Member

duncanmcclean commented Aug 28, 2024

This pull request fixes two issues with the recently added Dictionary fieldtype:

Option keys were being displayed in listing tables, rather than the labels.
Already selected options were able to be selected, when they shouldn't have been.

Fixes #10713.

duncanmcclean added 2 commits

August 28, 2024 17:28


          The value is our key.

cce6569

If we don't provide this prop, vue-select will look for an `id` property, which our options don't have, so it'll fallback to checking the objects which don't exactly match up.

Ref: https://github.com/sagalbot/vue-select/blob/d2643e37cf24d18e2d1930eea0647f82964b8222/src/components/Select.vue#L352-L388


          Display options using labels in fieldtype index

fd589c1

jackmcdade merged commit 55e057d into 5.x

18 checks passed

jackmcdade deleted the dictionary-fixes branch

August 30, 2024 19:18

Member

jackmcdade commented Aug 30, 2024

Nice one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet