Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.x] Updated the BulkAugmentor to be able to handle iterables that don't have sequential numeric keys #10512

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[5.x] Updated the BulkAugmentor to be able to handle iterables that don't have sequential numeric keys #10512

merged 1 commit into from
Jul 26, 2024

Conversation

kingsven
Copy link
Contributor

Fixes #10510

@jasonvarga jasonvarga merged commit fd24694 into statamic:5.x Jul 26, 2024
34 checks passed
@jasonvarga
Copy link
Member

Thank you.

FYI, looping over stuff in Antlers generally requires sequential keys anyway. In your TestBulkAugmentor tag in the issue, you should chain ->values() to the end so it would tidy up the keys. This PR is still a good change though. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BulkAugmentor fails to handle iterables that have non-sequential or non-numeric keys
3 participants
@kingsven @jasonvarga @simonworkhouse