[5.x] Fix augmentable not resolved in transient values #10417
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #9636 introduced the concept of transient values that are only resolved once they are needed. This PR fixes an issue that would make it impossible to get the
augmentable
from the Value, as it is never resolved.Consider this simple tag:
This is the dump:
Getting the augmentable would return
null
:So we need to resolve the value in the
augmentable()
method first to be able to get the augmentable entry: