Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Carousel Rotation #925

Closed
yoshnopa opened this issue Nov 5, 2020 · 1 comment · Fixed by #1008
Closed

Image Carousel Rotation #925

yoshnopa opened this issue Nov 5, 2020 · 1 comment · Fixed by #1008
Labels
improvement Something needed tweaking.
Milestone

Comments

@yoshnopa
Copy link
Contributor

yoshnopa commented Nov 5, 2020

Describe the bug
When getting to the last image of a page in galleries, it rotates back to the first one instead of continuing the gallery. This is of course mitigated by just increasing the page count to 1000, but it still is a design flaw that should be fixed in my opinion

To Reproduce
Steps to reproduce the behavior:

  1. Galleries or images
  2. Change to wall mode, reduce the number of results per page to a minimum
  3. Click on image, click on right (with mouse, see Image Navigation #923)
  4. Do so until you reach the end of the result page in the carousel and click once more. You're now on the first image again

Expected behavior
It should continue with the first image on the next page

@yoshnopa yoshnopa added the help wanted Extra attention is needed label Nov 5, 2020
@WithoutPants
Copy link
Collaborator

This will require a replacement of the lightbox component. I'll look at doing this in the next release.

@WithoutPants WithoutPants added this to the Version 0.5.0 milestone Nov 5, 2020
@WithoutPants WithoutPants added improvement Something needed tweaking. and removed help wanted Extra attention is needed labels Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants