Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug Report] Markers not cleared on navigation #5672

Closed
feederbox826 opened this issue Feb 22, 2025 · 4 comments · Fixed by #5684
Closed

[Bug Report] Markers not cleared on navigation #5672

feederbox826 opened this issue Feb 22, 2025 · 4 comments · Fixed by #5684
Labels
bug report Bug reports that are not yet verified

Comments

@feederbox826
Copy link
Contributor

feederbox826 commented Feb 22, 2025 •
edited
Loading

Describe the bug
Markers on the timeline are not cleared on video navigation

To Reproduce
Steps to reproduce the behavior:

  1. Open a video with markers (single timestamp)
  2. Let the video play to allow markers to appear on the seekbar)
  3. Navigate to another video with markers with in-video navigation
    Expected behavior
    Markers are cleared on video navigation events

Screenshots
Image

Stash Version: (from Settings -> About):
v0.27.2-61-g57e044e6,
v0.27.2-66-g587fd9e6
@feederbox826 feederbox826 added the bug report Bug reports that are not yet verified label Feb 22, 2025
@github-project-automation github-project-automation bot moved this to To triage in Bug fixing Feb 22, 2025
@feederbox826
Copy link
Contributor Author

demo.mp4

@feederbox826
Copy link
Contributor Author

feederbox826 commented Feb 25, 2025 •
edited
Loading

Related, #5671 seems to fix the problem with marker ranges but not single-point markers

@skier233
Copy link
Contributor

I'm able to reproduce. Trying to see why this might be happening.

@skier233 skier233 mentioned this issue Feb 25, 2025
Merged
@skier233
Copy link
Contributor

Thanks for catching this! Was a super easy fix once I found the problem area.

@github-project-automation github-project-automation bot moved this from To triage to Done in Bug fixing Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug report Bug reports that are not yet verified
Projects
Bug fixing
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix() point markers ui bug skier233/stash
2 participants
@skier233 @feederbox826