Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Tagger Settings are per browser, hidden and with problematic defaults #4982

Closed
BonerFide opened this issue Jun 18, 2024 · 0 comments · Fixed by #5165
Closed
Labels
bug report Bug reports that are not yet verified

Comments

@BonerFide
Copy link

BonerFide commented Jun 18, 2024

Describe the bug
When tagging via tagger view, the defaults for showMales, and setTags are false, and not persisted on the server.

Expected behavior
Defaults should not change without warning / being obvious because you use a new browser.

Stash Version: v0.26.1

Additional context
Because these are per browser (stored in IndexedDB) every time a new browser is used these are unset

The current defaults being false for both are thus a problem because it's not obvious that they have changed since you used another browser and they're hidden by default in a collapsed menu.

If they are false, tagger may return no tags / males because
a) they don't exist in the stash box entry
b) you haven't checked this option

If the default were set to true for both, this would prevent this issue, because, if the inverse settings were desired, the added tags and males being shown would make it obvious that you need to change the setting. This is probably the easiest fix, but others are suggested below.

The reason this is a problem is you might go and match a few hundred scenes, then have to go back and do them all again to get the data you thought you were getting the first time.

Alternatives:

  • Persist these settings server side
  • Expand the tagger settings by default until manually collapsed by the user, the first time on each browser
  • Make it more obvious that data is available (tags / males) that are not being added
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug report Bug reports that are not yet verified
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant