Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom scene cover #35

Closed
StashAppDev opened this issue Mar 24, 2019 · 6 comments
Closed

Custom scene cover #35

StashAppDev opened this issue Mar 24, 2019 · 6 comments
Labels
feature Pull requests that add a new feature

Comments

@StashAppDev
Copy link
Member

As discussed in discord:

maybe 20% by default, but having the option in the UI to upload an image as well. what ive been doing is pulling the "cover art" image from the torrent tracker site, and using that. useually is a image that came from a paysite gallery for the scene thats been perfectly croped and had sites logo added or somthing of the kind. looks better imho than just scrolling though random screenshots ( plus they tend to all look the same about 20% in on the same catagory of scene)

It would be nice to use a custom cover for a scene (like the official site image). Right now Stash generates screenshot files at 20% into the video. For this change this would act as a default, but we would also expand the scene model. There would need to be a new BLOB cover image property in the database. Stash should use this image if it exists, otherwise fall back to the screenshot.

@StashAppDev StashAppDev added the feature Pull requests that add a new feature label Mar 24, 2019
@echo6ix
Copy link
Contributor

echo6ix commented May 15, 2019

I look forward to this feature. Also consider generating a custom scene cover/thumbnail from the a user defined time during the scene. Similar to how a marker is currently generated.

@rexii2300
Copy link

yep this would be fantastic!

@WithoutPants
Copy link
Collaborator

I look forward to this feature. Also consider generating a custom scene cover/thumbnail from the a user defined time during the scene. Similar to how a marker is currently generated.

This is covered by #9

It would be nice to use a custom cover for a scene (like the official site image). Right now Stash generates screenshot files at 20% into the video. For this change this would act as a default, but we would also expand the scene model. There would need to be a new BLOB cover image property in the database. Stash should use this image if it exists, otherwise fall back to the screenshot.

Is there any reason we can't just replace the existing screenshot file with the submitted one? I'm not sure why we need to store a separate image in the database unless we're using the thumbnail image for something else.

@ueaslsef
Copy link
Contributor

@Leopere this seems done, should we close it?

@bnkai
Copy link
Collaborator

bnkai commented Mar 6, 2020

should be closed when #376 is merged

@bnkai
Copy link
Collaborator

bnkai commented Mar 13, 2020

closing since #376 was merged

@bnkai bnkai closed this as completed Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

No branches or pull requests

6 participants