From 5b840c626ff74f2c20dccf0f601208a510b55b40 Mon Sep 17 00:00:00 2001 From: raorao Date: Thu, 10 Oct 2019 17:09:11 -0700 Subject: [PATCH 1/3] upgrade to rubocop 0.73 --- Gemfile.lock | 8 ++++---- standard.gemspec | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index e8d53a29..c9b76714 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,7 +2,7 @@ PATH remote: . specs: standard (0.1.4) - rubocop (~> 0.72.0) + rubocop (~> 0.73.0) rubocop-performance (~> 1.4.0) GEM @@ -16,15 +16,15 @@ GEM json (2.1.0) method_source (0.9.2) minitest (5.11.3) - parallel (1.17.0) - parser (2.6.4.1) + parallel (1.18.0) + parser (2.6.5.0) ast (~> 2.4.0) pry (0.12.2) coderay (~> 1.1.0) method_source (~> 0.9.0) rainbow (3.0.0) rake (12.3.2) - rubocop (0.72.0) + rubocop (0.73.0) jaro_winkler (~> 1.5.1) parallel (~> 1.10) parser (>= 2.6) diff --git a/standard.gemspec b/standard.gemspec index 4857920e..3afd65f0 100644 --- a/standard.gemspec +++ b/standard.gemspec @@ -18,7 +18,7 @@ Gem::Specification.new do |spec| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_dependency "rubocop", "~> 0.72.0" + spec.add_dependency "rubocop", "~> 0.73.0" spec.add_dependency "rubocop-performance", "~> 1.4.0" spec.add_development_dependency "bundler", "~> 1.17" From 247c005e6309485a6d9be8ac9e920cde0fbba39e Mon Sep 17 00:00:00 2001 From: raorao Date: Thu, 10 Oct 2019 17:09:55 -0700 Subject: [PATCH 2/3] upgrade to rubocop 0.74 --- Gemfile.lock | 4 ++-- standard.gemspec | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index c9b76714..e802733e 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,7 +2,7 @@ PATH remote: . specs: standard (0.1.4) - rubocop (~> 0.73.0) + rubocop (~> 0.74.0) rubocop-performance (~> 1.4.0) GEM @@ -24,7 +24,7 @@ GEM method_source (~> 0.9.0) rainbow (3.0.0) rake (12.3.2) - rubocop (0.73.0) + rubocop (0.74.0) jaro_winkler (~> 1.5.1) parallel (~> 1.10) parser (>= 2.6) diff --git a/standard.gemspec b/standard.gemspec index 3afd65f0..d1a1ff9d 100644 --- a/standard.gemspec +++ b/standard.gemspec @@ -18,7 +18,7 @@ Gem::Specification.new do |spec| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_dependency "rubocop", "~> 0.73.0" + spec.add_dependency "rubocop", "~> 0.74.0" spec.add_dependency "rubocop-performance", "~> 1.4.0" spec.add_development_dependency "bundler", "~> 1.17" From 73ce59c9066c34f56d41965254498c3b15758f70 Mon Sep 17 00:00:00 2001 From: raorao Date: Thu, 10 Oct 2019 17:30:58 -0700 Subject: [PATCH 3/3] bump to rubocop 0.75 --- Gemfile.lock | 8 ++++---- config/base.yml | 2 -- standard.gemspec | 4 ++-- test/standard/runners/rubocop_test.rb | 7 ++++--- 4 files changed, 10 insertions(+), 11 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index e802733e..6b1d6973 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -2,8 +2,8 @@ PATH remote: . specs: standard (0.1.4) - rubocop (~> 0.74.0) - rubocop-performance (~> 1.4.0) + rubocop (~> 0.75.0) + rubocop-performance (~> 1.5.0) GEM remote: https://rubygems.org/ @@ -24,14 +24,14 @@ GEM method_source (~> 0.9.0) rainbow (3.0.0) rake (12.3.2) - rubocop (0.74.0) + rubocop (0.75.0) jaro_winkler (~> 1.5.1) parallel (~> 1.10) parser (>= 2.6) rainbow (>= 2.2.2, < 4.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 1.4.0, < 1.7) - rubocop-performance (1.4.1) + rubocop-performance (1.5.0) rubocop (>= 0.71.0) ruby-progressbar (1.10.1) simplecov (0.16.1) diff --git a/config/base.yml b/config/base.yml index 9232f95b..6c46c97e 100644 --- a/config/base.yml +++ b/config/base.yml @@ -568,11 +568,9 @@ Performance/CompareWithBlock: Performance/Count: Enabled: true - SafeMode: true Performance/Detect: Enabled: true - SafeMode: true Performance/DoubleStartEndWith: Enabled: true diff --git a/standard.gemspec b/standard.gemspec index d1a1ff9d..0e6da4d3 100644 --- a/standard.gemspec +++ b/standard.gemspec @@ -18,8 +18,8 @@ Gem::Specification.new do |spec| spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) } spec.require_paths = ["lib"] - spec.add_dependency "rubocop", "~> 0.74.0" - spec.add_dependency "rubocop-performance", "~> 1.4.0" + spec.add_dependency "rubocop", "~> 0.75.0" + spec.add_dependency "rubocop-performance", "~> 1.5.0" spec.add_development_dependency "bundler", "~> 1.17" spec.add_development_dependency "minitest", "~> 5.0" diff --git a/test/standard/runners/rubocop_test.rb b/test/standard/runners/rubocop_test.rb index b368967e..d6feb59d 100644 --- a/test/standard/runners/rubocop_test.rb +++ b/test/standard/runners/rubocop_test.rb @@ -50,11 +50,12 @@ def test_print_corrected_output_on_stdin C: 1: 1: [Corrected] Style/FrozenStringLiteralComment: Missing magic comment # frozen_string_literal: true. C: 1: 1: [Corrected] Style/SingleLineMethods: Avoid single-line method definitions. C: 1: 8: [Corrected] Layout/SpaceAfterSemicolon: Space missing after semicolon. + C: 2: 1: [Corrected] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments. + C: 2: 8: [Corrected] Style/Semicolon: Do not use semicolons to terminate expressions. + C: 2: 9: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. C: 3: 5: Naming/MethodName: Use snake_case for method names. - C: 3: 8: [Corrected] Style/Semicolon: Do not use semicolons to terminate expressions. - C: 3: 9: [Corrected] Layout/TrailingWhitespace: Trailing whitespace detected. - 1 file inspected, 6 offenses detected, 5 offenses corrected + 1 file inspected, 7 offenses detected, 6 offenses corrected ==================== # frozen_string_literal: true