Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛: "Push Subscriptions" Garbage Pile-Up #1248

Open
1 task done
zvasilev opened this issue Feb 25, 2025 · 0 comments
Open
1 task done

🐛: "Push Subscriptions" Garbage Pile-Up #1248

zvasilev opened this issue Feb 25, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@zvasilev
Copy link

What happened?

Implementing JMAP push against stalw.art.

Attached file is from JMAP Push get. All from one client(device).

It shows three problems:

  1. Multiple duplicate deviceClientId.
    This ID (device + app + time) is supposed to be unique, so it should also be enforced as unique on the server.
    The JMAP entry doesn’t have a timestamp, making it impossible to determine which entry is valid for subscription checking.

  2. There seems to be no cleanup process.
    Many entries have expired but remain in the system.

  3. For the client UI, it would be better if, after a few retries (e.g., 30 seconds) to the JMAP proxy server, the entry disappears, indicating an error.

PushSubscription-get.json

How can we reproduce the problem?

I can reproduce the problem by doing the following steps:

Version

v0.11.x

What database are you using?

RocksDB

What blob storage are you using?

RocksDB

Where is your directory located?

None

What operating system are you using?

MacOS

Relevant log output

Code of Conduct

  • I agree to follow this project's Code of Conduct
@zvasilev zvasilev added the bug Something isn't working label Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant