feat(core): improve signature of operators regarding types #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes core operators to return either: (1) Stream only, (2) Stream or MemoryStream, (3) MemoryStream only. Operators like fold() and startWith() now always return a MemoryStream, while operators like map(), take(), and endWhen() return the same type that the source/instance stream was. E.g. MemoryStream mapped will return a MemoryStream. BREAKING CHANGE: debug() now returns a MemoryStream if the input was also a MemoryStream. endWhen() now returns a MemoryStream if the input was also a MemoryStream. fold() now returns always a MemoryStream, not Stream. imitate() only works on conventional Stream, will throw error on MemoryStream. map() now returns a MemoryStream if the input was also a MemoryStream. mapTo() now returns a MemoryStream if the input was also a MemoryStream. replaceError() now returns a MemoryStream if the input was also a MemoryStream. startWith() now returns always a MemoryStream, not Stream. take() now returns a MemoryStream if the input was also a MemoryStream.
| @@ -1046,6 +1046,10 @@ export class Stream<T> implements InternalListener<T> { | |||
| } | |||
| } | |||
|
|
|||
| private ctor(): typeof Stream { | |||
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes core operators to return either: (1) Stream only, (2) Stream or MemoryStream,
(3) MemoryStream only. Operators like fold() and startWith() now always return a MemoryStream, while
operators like map(), take(), and endWhen() return the same type that the source/instance stream
was. E.g. MemoryStream mapped will return a MemoryStream.
BREAKING CHANGE:
debug() now returns a MemoryStream if the input was also a MemoryStream.
endWhen() now returns a MemoryStream if the input was also a MemoryStream.
fold() now returns always a MemoryStream, not Stream.
imitate() only works on conventional Stream, will throw error on MemoryStream.
map() now returns a MemoryStream if the input was also a MemoryStream.
mapTo() now returns a MemoryStream if the input was also a MemoryStream.
replaceError() now returns a MemoryStream if the input was also a MemoryStream.
startWith() now returns always a MemoryStream, not Stream.
take() now returns a MemoryStream if the input was also a MemoryStream.
@TylorS