Fixed $and condition being overridden on queries
#273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was |
…g `$and` conditions Fixes stalniy#272
stalniy
force-pushed
the
fix-and-condition-override
branch
from
253310c to
4a5cbcf
Compare
|
I did some minor changes to your code, removed tests that tests implementation and left only those that test behavior. Also used Everything else is good! Thank you very much for the contribution! |
|
@stalniy Thanks! I was searching the mongoose docs for a method that could get the conditions, must've just missed it. Glad you knew about it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #272
In order to test I needed to check the "private" attribute
_conditionson the query. This probably isn't preferable but I wasn't able to think of another way. If you happen to know of one I'll gladly make the change