Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(typescript): add rulesToFields definition #205

Merged
merged 1 commit into from
Jun 30, 2019
Merged

fix(typescript): add rulesToFields definition #205

merged 1 commit into from
Jun 30, 2019

Conversation

vonagam
Copy link
Contributor

@vonagam vonagam commented Jun 28, 2019

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          15       15           
  Lines         327      327           
=======================================
  Hits          323      323           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc76790...7804b99. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Jun 28, 2019 •
edited
Loading

Codecov Report

Merging #205 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #205   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          15       15           
  Lines         327      327           
=======================================
  Hits          323      323           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc76790...7804b99. Read the comment docs.

stalniy
stalniy approved these changes Jun 30, 2019
View reviewed changes
Copy link
Owner

@stalniy stalniy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Will release it tomorrow

@stalniy stalniy merged commit b772ad6 into stalniy:master Jun 30, 2019
@stalniy
Copy link
Owner

stalniy commented Jul 1, 2019

released in @casl/[email protected]

@vonagam
Copy link
Contributor Author

vonagam commented Jul 1, 2019

When will it be published?

@stalniy
Copy link
Owner

stalniy commented Jul 2, 2019

It must be available in npm, double check please

@vonagam
Copy link
Contributor Author

vonagam commented Jul 2, 2019

Oh, sorry, i was checking with yarn and at the moment it shows only 3.0.2. Seems like they have really long living cache.

@vonagam vonagam deleted the fix-ts-rules-to-fields branch July 2, 2019 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stalniy stalniy stalniy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vonagam @codecov-io @stalniy