Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DB host port #8

Closed
galanis-a opened this issue Nov 22, 2019 · 1 comment
Closed

DB host port #8

galanis-a opened this issue Nov 22, 2019 · 1 comment

Comments

@galanis-a
Copy link

Hello

i started using m2 builder and noticed that i can't set the port for the DB host. I'm mentioning it cause in my dev environment i my db instance in another server on the network, with multiple mysql instances that run on different ports than 3306.

It could have 3306 as default value and can be overwritten in build.properties file.

Also i think a user host would be nice to set the mysql user host in something like % or localhost independent from the db host setting.

I can make the changes and make a PR if you want.

Thanks

@jalogut
Copy link
Collaborator

jalogut commented Nov 23, 2019

Hi @galanis-a

Sure, if would be great if you could create a PR. For the host there is already a variable that you can overwrite (database.host)

For the port, you would have to edit following line to add the port on the connection command:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants