prevent parentheses in filenames being stripped out #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent parentheses in filenames from being incorrectly stripped out when parsing the raw stack frame.
This is done by changing
extractLocation, which previously removed all parens from its input, and now just strips them from the start and end (including multiple, which can happen with nested evals) which I think was probably the original intent.Motivation and Context
Fixes #62.
How Has This Been Tested?
Added a test with an example stack (thanks to @mattwynne work in #61)
Types of changes
Checklist:
npm run lintpasses without errorsnpm run testpasses without errors