Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky Test: tests::signer::v0::partial_tenure_fork #5767

Open
kantai opened this issue Jan 29, 2025 · 1 comment
Open

Flaky Test: tests::signer::v0::partial_tenure_fork #5767

kantai opened this issue Jan 29, 2025 · 1 comment
Assignees
Labels

Comments

@kantai
Copy link
Member

kantai commented Jan 29, 2025

Logs

@kantai kantai added the flaky label Jan 29, 2025
@kantai kantai self-assigned this Jan 29, 2025
@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Jan 29, 2025
@kantai
Copy link
Member Author

kantai commented Jan 29, 2025

I think what happened in this test is that miner 2 won the first testing tenure of the test. This, by itself, should be okay, but the problem is that the timing of the block commit pausing/unpausing and block processing are such that miner 2's first commit is actually a fork! This is because the CI runner builds the next bitcoin block before miner 2 has a chance to RBF their commit with one that points at miner 1's tenure. I can solve this particular flakiness with a new Counters variable, but like my last PR that added a Counters variable, this is a kind of check we do in a lot of places. For now, trying to refactor all of the tests to be better about this is a pretty big undertaking, but its something worth keeping in mind somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Status: 🆕 New
Development

No branches or pull requests

1 participant