Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[signer] event parity should apply to all incoming signer messages #5613

Closed
jferrant opened this issue Dec 23, 2024 · 3 comments
Closed

[signer] event parity should apply to all incoming signer messages #5613

jferrant opened this issue Dec 23, 2024 · 3 comments
Assignees
Labels

Comments

@jferrant
Copy link
Contributor

Currently event parity is only applied to a block proposal. It should be applied to both SignerEvent::BlockValidationResponse(_) and Some(SignerEvent::MinerMessages(..)). The lack of proper reward cycle checks caused the chain to stall. See #5612

This will require changes to both the node and the signer.

As part of this ticket, remove the parity check within the hotfix handle_block_validate_* fns as it should be done in the outer call (also prevents double incrementing metrics when they shouldn't be)

@github-project-automation github-project-automation bot moved this to Status: 🆕 New in Stacks Core Eng Dec 23, 2024
@jcnelson jcnelson added this to the 3.1.0.0.3 milestone Jan 3, 2025
@jferrant
Copy link
Contributor Author

jferrant commented Jan 8, 2025

Related to #5662

@aldur aldur removed this from the 3.1.0.0.4 milestone Jan 30, 2025
@aldur
Copy link
Collaborator

aldur commented Jan 30, 2025

Closing this since it might be fixed/not needed anymore. We can re-open if we need it.

@aldur aldur closed this as completed Jan 30, 2025
@github-project-automation github-project-automation bot moved this from Status: 🆕 New to Status: ✅ Done in Stacks Core Eng Jan 30, 2025
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Status: ✅ Done
Development

No branches or pull requests

4 participants