Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate block assembly paths for miner and follower #2914

Closed
pavitthrap opened this issue Nov 9, 2021 · 3 comments · Fixed by #2946
Closed

Consolidate block assembly paths for miner and follower #2914

pavitthrap opened this issue Nov 9, 2021 · 3 comments · Fixed by #2946
Assignees
@pavitthrap
Labels
locked next-cost

Comments

@pavitthrap
Copy link
Contributor

pavitthrap commented Nov 9, 2021 •
edited
Loading

Right now, a miner and follower follow different code paths for processing a block.

  • epoch_begin in miner.rs
  • append_block in chainstate/stacks/db/blocks.rs

The goal of this issue is to consolidate this logic.
@pavitthrap pavitthrap self-assigned this Nov 9, 2021
@kantai
Copy link
Member

kantai commented Nov 9, 2021

Related testing issue: #2913

@jcnelson jcnelson mentioned this issue Nov 10, 2021
Closed
@pavitthrap pavitthrap mentioned this issue Nov 22, 2021
Merged
@kantai kantai linked a pull request Nov 23, 2021 that will close this issue
Refactor: merge block assembly paths for follower and miner #2946
Merged
@jcnelson
Copy link
Member

jcnelson commented Feb 7, 2022

This is done in #2946.

@jcnelson jcnelson closed this as completed Feb 7, 2022
@blockstack-devops
Copy link
Contributor

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Nov 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pavitthrap pavitthrap

Labels
locked next-cost
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor: merge block assembly paths for follower and miner stacks-network/stacks-core
4 participants
@jcnelson @kantai @pavitthrap @blockstack-devops