From 2aed37464478784e7b5ee0c7c26dc60db013f827 Mon Sep 17 00:00:00 2001 From: Hank Stoever Date: Thu, 6 Feb 2025 07:24:03 -0800 Subject: [PATCH] fix: changelog, remove bad comments --- CHANGELOG.md | 2 ++ libsigner/src/events.rs | 2 -- libsigner/src/v0/messages.rs | 1 - 3 files changed, 2 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1f7fce479b..65f3f5285d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,8 @@ and this project adheres to the versioning scheme outlined in the [README.md](RE ### Added +- The `BlockProposal` StackerDB message serialization struct now includes a `server_version` string, which represents the version of the node that the mienr is using. ([#5803](https://github.com/stacks-network/stacks-core/pull/5803)) + ### Changed ### Fixed diff --git a/libsigner/src/events.rs b/libsigner/src/events.rs index e3ec6df7d9..68050639e5 100644 --- a/libsigner/src/events.rs +++ b/libsigner/src/events.rs @@ -141,7 +141,6 @@ impl BlockProposalData { /// Serialize the "inner" block response data. Used to determine the bytes length of the serialized block response data fn inner_consensus_serialize(&self, fd: &mut W) -> Result<(), CodecError> { write_next(fd, &self.server_version.as_bytes().to_vec())?; - // write_next(fd, &self.unknown_bytes)?; fd.write_all(&self.unknown_bytes) .map_err(CodecError::WriteError)?; Ok(()) @@ -708,7 +707,6 @@ mod tests { old_block_proposal.reward_cycle, new_block_proposal.reward_cycle ); - // assert_eq!(); } #[test] diff --git a/libsigner/src/v0/messages.rs b/libsigner/src/v0/messages.rs index ed0e8be25a..12a279e1fe 100644 --- a/libsigner/src/v0/messages.rs +++ b/libsigner/src/v0/messages.rs @@ -828,7 +828,6 @@ impl BlockResponseData { /// Serialize the "inner" block response data. Used to determine the bytes length of the serialized block response data fn inner_consensus_serialize(&self, fd: &mut W) -> Result<(), CodecError> { write_next(fd, &self.tenure_extend_timestamp)?; - // write_next(fd, &self.unknown_bytes)?; fd.write_all(&self.unknown_bytes) .map_err(CodecError::WriteError)?; Ok(())