From ce6a5eb867bcf892d4458e7ad478a09cf7f87b31 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Gerhard=20St=C3=B6bich?= Date: Mon, 30 Mar 2020 19:31:09 +0200 Subject: [PATCH] chore: remove unused default argument in Tracer (#913) A Tracer is always created by a TracerProvider and this one always passes it's config therefore no need to default in construtor. --- packages/opentelemetry-tracing/src/Tracer.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/packages/opentelemetry-tracing/src/Tracer.ts b/packages/opentelemetry-tracing/src/Tracer.ts index 9ca8e6a80e4..24408d80e48 100644 --- a/packages/opentelemetry-tracing/src/Tracer.ts +++ b/packages/opentelemetry-tracing/src/Tracer.ts @@ -27,7 +27,6 @@ import { } from '@opentelemetry/core'; import { Resource } from '@opentelemetry/resources'; import { BasicTracerProvider } from './BasicTracerProvider'; -import { DEFAULT_CONFIG } from './config'; import { Span } from './Span'; import { TraceParams, TracerConfig } from './types'; import { mergeConfig } from './utility'; @@ -46,7 +45,7 @@ export class Tracer implements api.Tracer { * Constructs a new Tracer instance. */ constructor( - config: TracerConfig = DEFAULT_CONFIG, + config: TracerConfig, private _tracerProvider: BasicTracerProvider ) { const localConfig = mergeConfig(config); @@ -163,7 +162,7 @@ function getParent( return getParentSpanContext(context); } -function getContext(span: api.Span | api.SpanContext) { +function getContext(span: api.Span | api.SpanContext): api.SpanContext { return isSpan(span) ? span.context() : span; }