Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtoReader RECURSION_LIMIT is not configurable and is not following protobuf default #3085

Closed
jianchaoxudd opened this issue Sep 3, 2024 · 6 comments

Comments

@jianchaoxudd
Copy link

Hi team,

The RECURSION_LIMIT=65 in ProtoReader is not configurable where grpc allows configurable limit and it is not following protobuf default(100)

@oldergod
Copy link
Member

oldergod commented Sep 4, 2024

Have you needed more than 65?

@jianchaoxudd
Copy link
Author

hey @oldergod ,

Yes, our service has more than 65 depth, but not more than 100(protobuf default) yet.

@oldergod
Copy link
Member

oldergod commented Sep 5, 2024

I think we'll change our value to 100 for now. We can offer an option to configure it in the future.

@jianchaoxudd
Copy link
Author

Sounds good. Changing to 100 is good enough for now.

@jianchaoxudd
Copy link
Author

Thanks for the quick fix! @oldergod , how long it takes to release the fix?

@oldergod
Copy link
Member

This week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants