variable tracking for assignment inside of def

[sqlalchemy-bot]

Migrated issue, originally created by Michael Bayer (@zzzeek)

from mako.template import Template
t = Template(
"""
<%
   def foo():
       s = 1
%>

""".strip(),
   strict_undefined=True,
)
t.render()

would rise "NameError: 's' is not defined"

---

Attachments: 192.2.patch | 192.patch

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

this is a likely patch which also cleans up "ident stack" a bit.

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

updated version generalizes names located within defs and fixes it for 2.4 as well.

new test:

t = Template(
"""
<%
   def foo():
       s = 1
       def bar():
           t = s
%>

""".strip(),
   strict_undefined=True,
)

t.render()

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

and more:

t = Template(
"""
<%
   def foo():
       class Bat(object):
           pass
       Bat
%>

""".strip(),
   strict_undefined=True,
)
# should pass
t.render()


t = Template(
"""
<%
   def foo():
       class Bat(object):
           pass
       Bat
%>

   ${Bat}

""".strip(),
   strict_undefined=True,
)
# should pass
t.render(Bat='adsf')

# should raise
t.render()

however, make sure we distill these into test_ast.py as more test_locate_identifiers tests.

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

91b7e5f

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed