History plugin: add an option to show/hide line numbers

[spyder-bot]

From [email protected] on 2012-03-11T00:27:55Z

Enhancement Request

When using Spyder with IPython it is often helpful to make quick macros of code when working on the command line. To do this efficiently, one must know which lines from the history to place in the macro. As I often work with the history visible it would be helpful if there were an option to display the history line numbers in the pane for easy reference.

Spyder 2.1.17
Windows 7 x64

Original issue: http://code.google.com/p/spyderlib/issues/detail?id=970

[spyder-bot]

From pierre.raybaut on 2012-03-18T08:55:30Z

Summary: History plugin: add an option to show/hide line numbers
Labels: -Type-Defect -Priority-Medium Type-Enhancement Priority-Low

[spyder-bot]

From pierre.raybaut on 2012-03-18T08:55:39Z

Labels: Cat-HistoryLog

[spyder-bot]

From pierre.raybaut on 2012-03-18T14:05:22Z

Labels: -Type-Enhancement Type-Enh

[spyder-bot]

From ccordoba12 on 2013-02-13T09:19:28Z

Labels: MS-v2.3

[spyder-bot]

From pierre.raybaut on 2013-05-11T05:51:59Z

Labels: -MS-v2.3 MS-v2.4

[csabella]

Would it be OK for me to work on this issue? I'll try to add tests for history.py at the same time.

[dalthviz]

Hi @csabella thanks for willing to help! and go ahead! just make sure to take as base of your PR the master branch :)

[rlaverde]

@csabella Thanks again for contributing to spyder 😄

You need to add a PanelManager and a LineNumberArea panel to it, you could take a look to the CodeEditor code (History shares the same base class with the editor and works somehow similar), If you need help ask us in gitter

[csabella]

I did it a little differently than adding a PanelManager, but it seems to work OK. It already creates an instance of CodeEditor, which has linenumber as a setup argument. Instead of it always being False, it's now controlled by config.

[rlaverde]

I did it a little differently than adding a PanelManager, but it seems to work OK. It already creates an instance of CodeEditor, which has linenumber as a setup argument. Instead of it always being False, it's now controlled by config.

I was wrong, I thought History inherits of TextEditBaseWidget instead of CodeEditor