Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate serialized length of modified objects in the Variable Explorer #7158

Closed
dalthviz opened this issue May 20, 2018 · 4 comments
Closed

Comments

@dalthviz
Copy link
Member

dalthviz commented May 20, 2018

This is causing huge memory leaks right now, so it's really critical for us to fix it.

@dalthviz dalthviz added this to the v3.3 milestone May 20, 2018
@dalthviz dalthviz self-assigned this May 20, 2018
@ccordoba12 ccordoba12 changed the title Validate length of changed objects to serialize in the Variable Explorer Validate serialized length of modified objects in the Variable Explorer May 20, 2018
@CAM-Gerlach
Copy link
Member

Is this related or the same as the cause of the memory leaks when modifying objects discussed and confirmed in #5830 , but never fixed?

@ccordoba12
Copy link
Member

ccordoba12 commented May 21, 2018

but never fixed?

I asked @dalthviz to open these issues because the memory leaks are caused by several things, not a single one.

Besides, he's going to work on them in the next couple of weeks.

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented May 21, 2018

Okay, great! Glad to hear. So is some combination of these the underlying cause of #5830? Should it be closed as a duplicate, then?

@ccordoba12
Copy link
Member

It's not a duplicate. That issue made me realize all these problems, so leave it open for now. We'll see what to do about it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants