Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an authentication dialog to send reports to Github #6617

Closed
ccordoba12 opened this issue Mar 6, 2018 · 4 comments
Closed

Use an authentication dialog to send reports to Github #6617

ccordoba12 opened this issue Mar 6, 2018 · 4 comments

Comments

@ccordoba12
Copy link
Member

ccordoba12 commented Mar 6, 2018

I recently learned about the QCrash package (thanks @gmarull!):

https://github.com/ColinDuquesnoy/QCrash

which has a very nice dialog to authenticate users and open an issue on Github on behalf of them:

https://github.com/ColinDuquesnoy/QCrash/blob/master/docs/_static/qcrash_github_login.png

Since QCrash is licensed MIT, I think we should use this dialog after users press our Submit to Github button. Our current approach is not working as expected because I've seen several issues without a traceback and other empty ones.

@dalthviz, please work on this by:

  1. Copying that dialog to our source code.
  2. Adding the githubpy dependency to our utils/external module.
  3. Remove the keyring dependency used to save passwords through the Remember me checkbox of that dialog.
@ccordoba12 ccordoba12 added this to the v3.2.8 milestone Mar 6, 2018
@ccordoba12
Copy link
Member Author

ccordoba12 commented Mar 6, 2018

By the way, the problem with keyring is that it's a new dependency and it's not packaged correctly in conda for Linux. But we could use it for Spyder 4 :-)

@CAM-Gerlach
Copy link
Member

@ccordoba12 Sounds like a good plan; yeah, I've seen quite a few of those too. Some less observant users are clearly still missing the "Paste here to complete reporting" message or otherwise mishandling that, even though added more emphasis to the latter to try to make it harder to miss. This definitely looks a lot slicker, and potentially could open up additional enhancement opportunities down the road. I assume this all uses the Github API with the user's credentials, and everything else is handled automatically?

@ccordoba12
Copy link
Member Author

I assume this all uses the Github API with the user's credentials, and everything else is handled automatically?

Yes, that's right.

@gmarull
Copy link

gmarull commented Mar 6, 2018

If you need any help let me know :-) I have also used QCrash with sentry.io or rollbar (i.e. custom backend), they are great to discover bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants