Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Show blank spaces" with split view editor #5711

Closed
msancheznet opened this issue Nov 9, 2017 · 5 comments
Closed

"Show blank spaces" with split view editor #5711

msancheznet opened this issue Nov 9, 2017 · 5 comments

Comments

@msancheznet
Copy link

Description of your problem

What steps will reproduce the problem?

  1. Open a file in Spyder and create a split view in the editor
  2. In the left copy of the file, click "Source" -> "Show blank spaces". This adds marking to left copy of the file.
  3. Click on the right copy of the file, which does not have the "blank spaces" markings
  4. Click on "Source" again, and the tick for "Show blank spaces" remains active even though it is not for this part of the split view

What is the expected output? What do you see instead?
I would expect the "Show blank spaces" to either:

  1. Be synchronized with the view that the user is currently focusing on in the editor
  2. Activate/deactivate the markings in all views at the same time.

Please provide any additional information below

Versions and main components

  • Spyder Version: 3.2.4
  • Python Version: 3.6.2
  • Qt Version: 5.6.2
  • PyQt Version: 5.6.0
  • Operating system: Windows 10

Dependencies

Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:

IPython >=4.0 : 6.1.0 (OK)
cython >=0.21 : None (NOK)
jedi >=0.9.0 : 0.10.2 (OK)
nbconvert >=4.0 : 5.3.1 (OK)
numpy >=1.7 : 1.13.3 (OK)
pandas >=0.13.1 : 0.21.0 (OK)
pycodestyle >=2.3: 2.3.1 (OK)
pyflakes >=0.6.0 : 1.6.0 (OK)
pygments >=2.0 : 2.2.0 (OK)
pylint >=0.25 : 1.7.4 (OK)
qtconsole >=4.2.0: 4.3.1 (OK)
rope >=0.9.4 : 0.10.5 (OK)
sphinx >=0.6.6 : 1.6.3 (OK)
sympy >=0.7.3 : None (NOK)

@ccordoba12 ccordoba12 added this to the v3.2.x milestone Nov 9, 2017
@ccordoba12
Copy link
Member

Thanks for reporting. We'll take a look at it in a future release.

@csabella
Copy link
Contributor

I cannot recreate this. When I follow the steps to recreate it, after I click on 'Show Blank Spaces', both panels show the markings, so they are synchronized. If I unclick the Show Blank Spaces, the markings go away. I tried doing both from each panel.

I'm on Linux though, so either this might be a Windows-only issue or it was fixed on a recent release.

@msancheznet
Copy link
Author

msancheznet commented Feb 27, 2018

Maybe an earlier release fixed part of the problem but I can still recreate like this:

  1. Open a file in Spyder and create a split view in the editor
  2. Open two files, let's say "file 1.py" and file 2.py".
  3. Select "file 1.py" on the left view and "file 2.py" on the right view
  4. Click on the left view, then "Source" -> "Show blank spaces". This adds markings only on the left view.
  5. Click on the right view (containing file 2.py, no markings)
  6. Go to "Source" -> "Show blank spaces". Notice how the "Show blank spaces" tick is on even though the cursor is in file that does not show markings

NOTE: I updated to Spyder 3.2.7-py36 before reproducing the bug again

@csabella
Copy link
Contributor

csabella commented Mar 2, 2018

Thank you for the new information. It seems that with two files, a split screen isn't even needed to recreate the issue. When the Show blank spaces is clicked, it only affects the file being edited and not the other ones that are open.

This does not seem to be an issue in Spyder 4.0 (master branch) as all the source files show the blank spaces when the checkbox is clicked. Although, I couldn't find the exact project that resulted in the fix as there are many new options add to the Source menu for the future release.

@ccordoba12 ccordoba12 modified the milestones: v3.2.x, v4.0beta1 Mar 2, 2018
@ccordoba12
Copy link
Member

@csabella, @rlaverde fixed that in master by making all entries in the Source menu to apply to all files and also save the change in our config system.

I'm closing this since it's already solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants