Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Find in Files improvements #4490

Closed
ccordoba12 opened this issue May 18, 2017 · 2 comments
Closed

More Find in Files improvements #4490

ccordoba12 opened this issue May 18, 2017 · 2 comments

Comments

@ccordoba12
Copy link
Member

ccordoba12 commented May 18, 2017

seleccion_002

I used the new Find in Files after PR #4056 was merged, and these are my suggestions to improve your previous work @andfoy (which, by the way, was great!):

  1. Results must be shown in ascending order, i.e. first line 1, then line 3, etc. Right now results are shown in descending order (please take a look at the screenshot).

  2. We need to remove information about columns. For example, in the screenshot you can see two results about line 1 (one for column 5, the other for column 0). We simply need to report one entry per line (as it's done in ack or ag).

  3. The name of the file must be in bold. Example (from the screenshot):

    spam.txt - /home/carlos/Projects/...
    -> ...

  4. The line number must in bold too, the text inside the line must use a monospaced font, and the results detected inside it must be in bold too. Example (from the screenshot):

    3: lore ipsum sit dolorspam

  5. After a file is completely searched, its results need to be expanded automatically. This avoids the need of pressing the expand button every time you search for something (which becomes tiresome :-).

  6. Icons for file types need to be changed to use file-o from FontAwesome:

    https://github.com/spyder-ide/spyder/blob/master/spyder/utils/icon_manager.py#L175

@andfoy
Copy link
Member

andfoy commented May 18, 2017

With respect to the column information, I decided to display all the results independently, because sometimes a search match can be found on files that contain a single text line, such as minified Javascript sources. On such cases, displaying the match elements may be more difficult if the result is shown on a single line

@goanpeca
Copy link
Member

We need to remove information about columns. For example, in the screenshot you can see two results about line 1 (one for column 5, the other for column 0). We simply need to report one entry per line (as it's done in ack or ag).

Yeah, I agree with @andfoy, I am not convinced with removing the column info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants