Improve indentation tests

[rlaverde]

Indentation tests only test for indentation using spaces, and It's necessary to also test for indentation using tabs (that is partially broken #3508)

I'm thinking about using parametrize fixture to make test support several options

and I have consider different ways to organize test:

1: Each test will have parametrize options for tabs and spaces:

@pytest.mark.parametrize("indent_chars, text_input, expected", [
    ("    ", "\ndef function():\n", "\ndef function():\n    "),
    ("\t", "\ndef function():\n", "\ndef function():\n\t"),
])
def test_def_with_newline(indent_chars, text_input, expected):
    text = get_indent_fix(text_input, indent_chars)
    assert text == expected, repr(text)

2. Each test will have parametrize options for tabs and spaces, but strings will be generated into the test:

@pytest.mark.parametrize("indent_chars", [
    ("    "), ("\t"),
])
def test_def_with_newline(indent_chars):
    text = get_indent_fix("\ndef function():\n", indent_chars)
    assert text == "\ndef function():\n" + indent_chars, repr(text)

3. will be one test or maybe two (tabs and spaces) with several parametrized options:

@pytest.mark.parametrize("indent_chars, text_input, expected", [
    ("    ", "\ndef function():\n", "\ndef function():\n    "),
    ("\t", "\ndef function():\n", "\ndef function():\n\t"),

    ("    ","def function():\n    print []\n" , "def function():\n\tprint []\n    "),
    ("\t","def function():\n\tprint []\n" , "def function():\n\tprint []\n\t"),
])
def test_indentation(indent_chars, text_input, expected):
    text = get_indent_fix(text_input, indent_chars)
    assert text == expected, repr(text)

which option could be the best?

cc: @Nodd @goanpeca

[ccordoba12]

Was this already fixed in #3680 @rlaverde?

[ccordoba12]

Sorry, #3663?

[rlaverde]

Yes, I implemented the third way