Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing Ctrl+P twice opens file switcher twice #3297

Closed
pitrou opened this issue Jul 17, 2016 · 4 comments
Closed

Pressing Ctrl+P twice opens file switcher twice #3297

pitrou opened this issue Jul 17, 2016 · 4 comments

Comments

@pitrou
Copy link

pitrou commented Jul 17, 2016

Description of your problem

What steps will reproduce the problem?

  1. Press Ctrl-P
  2. Press Ctrl-P again

What is the expected output? What do you see instead?

The first Ctrl-P opens the selection pop up. The second Ctrl-P should (preferably) close it while open, or at least do nothing. Instead, it seems a second pop up is opened over the first one (you then have to press Esc twice to close both of them).

Versions and main components

  • Spyder Version: Spyder 3.0.0.dev0 (from spyder-ide conda channel)
  • Python Version: 3.5.2
  • Operating system: Linux

Dependencies

Please go to the menu entry Help > Optional Dependencies (or
Help > Dependencies), press the button Copy to clipboard
and paste the contents below:

jedi >=0.8.1 : 0.9.0 (OK)
matplotlib >=1.0 : None (NOK)
nbconvert >=4.0 : 4.2.0 (OK)
numpy >=1.7 : None (NOK)
pandas >=0.13.1 : None (NOK)
pep8 >=0.6 : 1.7.0 (OK)
psutil >=0.3 : 4.3.0 (OK)
pyflakes >=0.6.0 : 1.2.3 (OK)
pygments >=2.0 : 2.1.3 (OK)
qtconsole >=4.2.0: 4.2.1 (OK)
rope >=0.9.4 : 0.9.4-1 (OK)
sphinx >=0.6.6 : 1.4.1 (OK)
sympy >=0.7.3 : None (NOK)

@ccordoba12 ccordoba12 added this to the v3.0rc1 milestone Jul 17, 2016
@ccordoba12
Copy link
Member

Thanks for reporting @pitrou! I verified that the error is present in master.

@goanpeca
Copy link
Member

@ccordoba12, are you working on this?

Not sure if pressing Ctrl+P should close it (this is similar to something I requested about hiding dockwidgets if the same shortcut used to show it also served to hide), I think ESC is a pretty natural choice.

@jitseniesen thoughts?

@Nodd
Copy link
Contributor

Nodd commented Jul 18, 2016

You need to focus dockwidgets more often than closing them. The popup on the other hand in constantly being shown and hidden, so I feel it's a more natural choice to toggle it with the shortcut.

@ccordoba12
Copy link
Member

I feel it's a more natural choice to toggle it with the shortcut

I agree with @Nodd on this one. Pressing Ctrl+P should toggle the switcher between visible and hidden.

@ccordoba12 ccordoba12 changed the title Pressing Ctrl P twice opens two pop ups Pressing Ctrl+P twice opens two file switcher twice Jul 20, 2016
@ccordoba12 ccordoba12 changed the title Pressing Ctrl+P twice opens two file switcher twice Pressing Ctrl+P twice opens file switcher twice Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants