Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix on dot completion leads to dot replacement #20331

Closed
stonebig opened this issue Jan 8, 2023 · 4 comments
Closed

Fix on dot completion leads to dot replacement #20331

stonebig opened this issue Jan 8, 2023 · 4 comments

Comments

@stonebig
Copy link
Contributor

stonebig commented Jan 8, 2023

on this 2023-01-08 early morning master of 5.X da661cc

the dot completion works again, but if we validate a choice, the dot is replaced also, if we don't type a first letter of the world choosen

GIF_dot_completion_20230108

@ccordoba12 ccordoba12 changed the title fix on dot completion leads to dot replacement Fix on dot completion leads to dot replacement Jan 8, 2023
@ccordoba12
Copy link
Member

Good catch @stonebig! Thanks a lot for testing my fix on PR #20298.

I just checked that dot completions were working again, not that selecting one of them introduced the right text. I'll fix this right away.

@ccordoba12 ccordoba12 added this to the v5.4.2 milestone Jan 8, 2023
@ccordoba12 ccordoba12 self-assigned this Jan 8, 2023
@stonebig
Copy link
Contributor Author

stonebig commented Jan 8, 2023

spend hour on trying to find where to fix... but truly couldn't.

@juliangilbey
Copy link
Contributor

Hi @ccordoba12! This probably isn't quite the right place to ask this, but if you're going to release 5.4.2 to fix this, which depends on an as-yet-unreleased version of python-lsp-server (handling the newer pydocstyle), please could you release that first and update the spyder dependencies?

@ccordoba12
Copy link
Member

ccordoba12 commented Jan 11, 2023

Yep, that's the plan. I'll release pylsp 1.7.1 later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants