From bfdc1827e29b361eb2225cabf141bfc643839f32 Mon Sep 17 00:00:00 2001 From: jsbautista Date: Thu, 30 Jan 2025 23:02:21 -0500 Subject: [PATCH] apply suggestions --- spyder/plugins/ipythonconsole/plugin.py | 12 ++++++++++++ .../ipythonconsole/widgets/main_widget.py | 16 +++++----------- spyder/plugins/maininterpreter/container.py | 1 - 3 files changed, 17 insertions(+), 12 deletions(-) diff --git a/spyder/plugins/ipythonconsole/plugin.py b/spyder/plugins/ipythonconsole/plugin.py index d63e7281c68..c4796157adc 100644 --- a/spyder/plugins/ipythonconsole/plugin.py +++ b/spyder/plugins/ipythonconsole/plugin.py @@ -240,6 +240,9 @@ def on_initialize(self): widget = self.get_widget() # Main widget signals + # Connect signal to open preferences + widget.sig_open_preferences_requested.connect( + self._open_interpreter_preferences) widget.sig_append_to_history_requested.connect( self.sig_append_to_history_requested) widget.sig_switch_to_plugin_requested.connect(self.switch_to_plugin) @@ -590,6 +593,15 @@ def _rename_remote_clients(self, server_id): def _update_envs(self, envs): self.get_widget().update_envs(envs) + def _open_interpreter_preferences(self): + """Open the Preferences dialog in the main interpreter section.""" + self._main.show_preferences() + preferences = self._main.preferences + container = preferences.get_container() + dlg = container.dialog + index = dlg.get_index_by_name("main_interpreter") + dlg.set_current_index(index) + # ---- Public API # ------------------------------------------------------------------------- diff --git a/spyder/plugins/ipythonconsole/widgets/main_widget.py b/spyder/plugins/ipythonconsole/widgets/main_widget.py index 7cfac1ee6f8..9ac5e76d1b6 100644 --- a/spyder/plugins/ipythonconsole/widgets/main_widget.py +++ b/spyder/plugins/ipythonconsole/widgets/main_widget.py @@ -108,6 +108,10 @@ class IPythonConsoleWidget(PluginMainWidget, CachedKernelMixin): """ # Signals + sig_open_preferences_requested = Signal() + """ + Signal to open the main interpreter preferences. + """ sig_append_to_history_requested = Signal(str, str) """ This signal is emitted when the plugin requires to add commands to a @@ -389,8 +393,7 @@ def __init__(self, name=None, plugin=None, parent=None): self.sig_interpreter_changed ) self.pythonenv_status.sig_open_preferences_requested.connect( - self._open_interpreter_preferences - ) + self.sig_open_preferences_requested) # Initial value for the current working directory self._current_working_directory = get_home_dir() @@ -1163,15 +1166,6 @@ def _init_asyncio_patch(self): asyncio.set_event_loop_policy( WindowsSelectorEventLoopPolicy()) - def _open_interpreter_preferences(self): - """Open the Preferences dialog in the main interpreter section.""" - self._main.show_preferences() - preferences = self._main.preferences - container = preferences.get_container() - dlg = container.dialog - index = dlg.get_index_by_name("main_interpreter") - dlg.set_current_index(index) - @Slot() def _create_client_for_kernel(self): """Create a client connected to an existing kernel""" diff --git a/spyder/plugins/maininterpreter/container.py b/spyder/plugins/maininterpreter/container.py index 91ac366ecbd..59218fed9ab 100644 --- a/spyder/plugins/maininterpreter/container.py +++ b/spyder/plugins/maininterpreter/container.py @@ -55,7 +55,6 @@ class MainInterpreterContainer(PluginMainContainer): :py:meth:`spyder.utils.envs.get_list_envs`. """ - def __init__(self, *args, **kwargs): super().__init__(*args, **kwargs)