Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong or undocumented proxy exclusions list #1495

Closed
gianpaolo-lopresti opened this issue Mar 1, 2025 · 5 comments
Closed

Wrong or undocumented proxy exclusions list #1495

gianpaolo-lopresti opened this issue Mar 1, 2025 · 5 comments
Assignees

Comments

@gianpaolo-lopresti
Copy link

gianpaolo-lopresti commented Mar 1, 2025

Describe the bug
In the RestTemplateFactory class here:

https://github.com/spring-projects/sts4/blob/main/headless-services%2Fspring-boot-language-server%2Fsrc%2Fmain%2Fjava%2Forg%2Fspringframework%2Fide%2Fvscode%2Fboot%2Fapp%2FRestTemplateFactory.java

You can see that the code fetches the no proxy list from the http.proxy-exclusions vscode property: this is not the official vscode property for this, since it's instead http.noProxy (which can contains "*")

To Reproduce
Try to set the http.noProxy variable to exclude a host from proxy: the RestTemplateFactory still uses the proxy

Sample

@BoykoAlex
Copy link
Contributor

This is likely to be the fix #1496... @gianpaolo-lopresti does this look as you'd expect?

@gianpaolo-lopresti
Copy link
Author

Hi @BoykoAlex , yes it's the same. Sorry i didn't see that before.

@BoykoAlex
Copy link
Contributor

The fix was created only now in response to this issue - thanks very much for reporting it!!!
Since you looked at the RestTemplateFactory I just decided to run the fix by you as well in case I'm still missing something.

@gianpaolo-lopresti
Copy link
Author

Thanks to you!

@BoykoAlex BoykoAlex added this to the 4.29.0.RELEASE milestone Mar 2, 2025
@BoykoAlex
Copy link
Contributor

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants