Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusion in contribution guidelines regarding PR vs Issue #23427

Closed
Syquel opened this issue Aug 7, 2019 · 1 comment
Closed

Confusion in contribution guidelines regarding PR vs Issue #23427

Syquel opened this issue Aug 7, 2019 · 1 comment
Assignees
Labels
type: task A general task

Comments

@Syquel
Copy link

Syquel commented Aug 7, 2019

The contribution guidelines and the default Issue template on GitHub are inconsistent and confusing in regard to whether to create a Pull Request and / or a GitHub Issue.

While the default template for new issues states

Issue or Pull Request? Create only one, not both.

the CONTRIBUTING.md in the section "Submit a Pull Request" states

For all but the most trivial of contributions, please create a ticket.

It would be great to have that consistent, because I don't know if I should create an issue for my pending pull requests and rewrite my commits to include the ticket number or not.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Aug 7, 2019
@Syquel Syquel changed the title Confusion in contibution guidelines regarding PR vs Issue Confusion in contribution guidelines regarding PR vs Issue Aug 7, 2019
@snicoll
Copy link
Member

snicoll commented Aug 7, 2019

Thanks for bringing this to our attention @Syquel. The former is the most accurate version so please submit your PR right away.

@rstoyanchev rstoyanchev self-assigned this Sep 11, 2019
@rstoyanchev rstoyanchev added type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: task A general task
Projects
None yet
Development

No branches or pull requests

4 participants