-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce KIterablePropertyPath
#3241
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mipo256 <[email protected]>
e3e4f9e
to
c97078f
Compare
KIterablePropertyPath
`
KIterablePropertyPath
`KIterablePropertyPath
mp911de
reviewed
Feb 10, 2025
|
||
class User(val addresses: List<Address>) | ||
|
||
class Address(val street: String) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Space indents
mp911de
reviewed
Feb 10, 2025
*/ | ||
internal fun asString(property: KProperty<*>): String { | ||
return when (property) { | ||
is KPropertyPath<*, *> -> | ||
"${asString(property.parent)}.${property.child.name}" | ||
is KIterablePropertyPath<*, *> -> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: Space indents
mp911de
pushed a commit
that referenced
this pull request
Feb 10, 2025
…s using collections. See #3010 Original pull request: #3241 Signed-off-by: mipo256 <[email protected]>
Thank you for your contribution. That's merged and polished now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3010. Fixes the issue in the type safe way, so that this now works :
Where
toDotPath()
renders toaddresses.street
. In order to solve this ticket in the type safe way, without easing the generic boundary fromKProperty1<T, U>
toKProperty1<Any, U>
, a newKIterablePropertyPath
needs to be introduced. The solution withKProperty1<Any, U>
allows for non type safe usages of the API, which is not generally a good idea to begin with.