Formatter conflicts with "Only one statement per line" checkstyle rule

[michael-simons]

I have the following code:

try (Session session = this.driver.session();
		Transaction tx = session.beginTransaction()) {
		// Do something
}

Spring Java Format complains

 Formatting violations found in the following files:
 * /Users/msimons/Projects/spring-projects/spring-boot/spring-boot-project/spring-boot-autoconfigure/src/test/java/org/springframework/boot/autoconfigure/neo4j/Neo4jDriverAutoConfigurationIntegrationTests.java

Run `spring-javaformat:apply` to fix.

Fix turns the snippet into

try (Session session = this.driver.session(); Transaction tx = session.beginTransaction()) {
}

Checkstyle complains OneStatementPerLine.

I have no clue how to format the thing.

[snicoll]

@philwebb can you please transfer the issue to the spring-javaformat project?

[michael-simons]

There are examples where the formatter accepts this style.

org.springframework.boot.autoconfigure.admin.SpringApplicationAdminJmxAutoConfigurationTests#onlyRegisteredOnceWhenThereIsAChildContext

Difference here: The second autoclosable doesn't depend on the first.

[philwebb]

can you please transfer the issue to the spring-javaformat project?

Apparently not! The GitHub UI doesn't seem to offer it to me. Perhaps it's because it's part of a different organization. I'll do a brute force copy paste.

We actually hit it ourselves (see this comment) and in the end decided that fixing it would take more effort than refactoring the code to use multiple try blocks.

@michael-simons can you use the following form for now?

try (Session session = this.driver.session()) {
    try (Transaction tx = session.beginTransaction()) {
        // Do something
    }
}

[philwebb]

spring-io/spring-javaformat#136

[michael-simons]

michael-simons can you use the following form for now?

Of course.