Optimize regex in trimAdjacentBlankLines() method of ExtractedTextFormatter to prevent stack overflow #2248
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solenyk
force-pushed
the
bugfix/optimize-extracted-text-formatter-trim-regex
branch
2 times, most recently
from
2572e69 to
9bcd4cc
Compare
…matter to prevent stack overflow Closes 2247 issue Signed-off-by: Iryna Kopchak <[email protected]>
solenyk
force-pushed
the
bugfix/optimize-extracted-text-formatter-trim-regex
branch
from
9bcd4cc to
48900fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes were made to close issue 2247. The optimized regular expression works even with files containing 1500+ empty lines (I tested on files up to 2000 empty lines) on VM settings -Xss256k.
I also removed the
finalkeyword from the class declaration because I see cases for its inheritance (for example, right now I was forced to copy the entire class in order to rewrite the regex for my code).