Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SaveActions failed with Eclipse 2020-06 & 2020-09 #253

Closed
joteri opened this issue Dec 22, 2020 · 4 comments
Closed

SaveActions failed with Eclipse 2020-06 & 2020-09 #253

joteri opened this issue Dec 22, 2020 · 4 comments

Comments

@joteri
Copy link

joteri commented Dec 22, 2020

Hi, I was hoping you could give me a hand with this error I'm having when I save certain classes and the save actions apply.

It doesn't happen with just any class, only with some classes. And i've found that commenting every switch case out and leaving just the default one seems to prevent the crash.

I have tried to change the implementation used by the formatter to "Eclipse [Built-in]" instead of "Spring" and I have not experienced the same problem again.

I use Eclipse 2020-06 and version 0.0.26 of spring-javaformat. Tried to test with Eclipse 2020-09 but the problem persists.

https://github.com/joteri/spring-javaformat-issue-files -> The link to the repository with the class causing the error, the stacktrace and the error window that appears.

Do you know what the error may be? Thanks in advance, a greeting.

@philwebb
Copy link
Contributor

philwebb commented Jan 6, 2021

Could you try release 0.0.27 with Eclipse 2020-12 and let me know if the problem is still there? I couldn't get your sample file to fail with that release.

@joteri
Copy link
Author

joteri commented Jan 13, 2021

I did the same test with the 0.0.27 and eclipse 2020-12 and everything worked fine.

I have tried this last release with the 2020-06 and 2020-09 but it results in memory problems.

I have no problem upgrading to the latest version of Eclipse but I was hoping you could answer the following question, What is the reason for the lack of compatibility with previous platforms? Is it due to its complexity or is it due to ruptured changes in the Eclipse API?

Thanks for your help.

@philwebb
Copy link
Contributor

I'm honestly not sure why things sometimes break during an upgrade. I wanted to look into it a little more to see if we could stop it happening. Unfortunately, I haven't had the time.

@wilkinsona
Copy link
Contributor

#288 has hopefully taken care of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants