Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using Gradle, upgrading from 0.0.15 to 0.0.17 results in unexpected formatting changes #161

Closed
wilkinsona opened this issue Jan 7, 2020 · 1 comment
Milestone

Comments

@wilkinsona
Copy link
Contributor

I think this is Gradle-specific so it may have been caused by #148. Upgrading to 0.0.17 (from 0.0.15) results in some unexpected changes in formatting:

  • Javadoc line width is narrowed
  • The description for javadoc @param tags is split onto a separate line:
 * @param name
 *            name of the library
  • catch is moved onto the same line as the closing } of the try block
} catch (IOException ex) {
@ttddyy
Copy link
Contributor

ttddyy commented Jan 7, 2020

I started applying spring-javafomat plugin to our library yesterday, and noticed @param behavior too.
It would be appreciated to decide either fix this or go with this change going forward. So that, I can decide whether to use 0.0.17 or 0.0.15 to our code base.
I'd like to be consistent in our code style with spring-boot since my library is built on top of spring-boot; so code-style consistency is nice to have.

@wilkinsona wilkinsona changed the title When using Gradle, upgrading from 0.0.15 to 0.0.17 results in unexpected formatting changes. When using Gradle, upgrading from 0.0.15 to 0.0.17 results in unexpected formatting changes Jan 8, 2020
@wilkinsona wilkinsona added this to the 0.0.18 milestone Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants