Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark maven plugin as thread safe #133

Closed
Dunemaster opened this issue Jun 29, 2019 · 2 comments
Closed

Mark maven plugin as thread safe #133

Dunemaster opened this issue Jun 29, 2019 · 2 comments

Comments

@Dunemaster
Copy link

Dunemaster commented Jun 29, 2019

Currently, the plugin is not marked thread-safe which results in the following message when building, for example, spring boot using parallel builder

$ mvnw clean package -T3 -DskipTests --offline

[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in Spring Boot Docs:
[WARNING] *****************************************************************
[WARNING] * Your build is requesting parallel execution, but project      *
[WARNING] * contains the following plugin(s) that have goals not marked   *
[WARNING] * as @threadSafe to support parallel building.                  *
[WARNING] * While this /may/ work fine, please look for plugin updates    *
[WARNING] * and/or request plugins be made thread-safe.                   *
[WARNING] io.spring.javaformat:spring-javaformat-maven-plugin:0.0.15
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************
[WARNING] * If reporting an issue, report it against the plugin in        *
[WARNING] * question, not against maven-core                              *
[WARNING] *****************************************************************
[WARNING] The following plugins are not marked @threadSafe in Spring Boot Actuator Starter:
[WARNING] io.spring.javaformat:spring-javaformat-maven-plugin:0.0.15
[WARNING] Enable debug to see more precisely which goals are not marked @threadSafe.
[WARNING] *****************************************************************
@Dunemaster
Copy link
Author

Dunemaster commented Jun 29, 2019

I looked through the code, and it seems thread-safe for me, so it should be just a matter of setting threadsafe = true in the @Mojo annotations

@philwebb philwebb added this to the 0.0.16 milestone Dec 4, 2019
@philwebb
Copy link
Contributor

philwebb commented Dec 4, 2019

Fixed in f57fa92 (accidentally referenced the wrong issue).

@philwebb philwebb closed this as completed Dec 4, 2019
@philwebb philwebb modified the milestones: 0.0.16, 0.0.17 Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants