Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Add metrics sample #2455

Merged
merged 4 commits into from
Jul 14, 2020
Merged

Add metrics sample #2455

merged 4 commits into from
Jul 14, 2020

Conversation

eddumelendez
Copy link
Contributor

See gh-2403

@codecov
Copy link

codecov bot commented Jul 8, 2020 •
edited
Loading

Codecov Report

Merging #2455 into master will decrease coverage by 7.24%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #2455      +/-   ##
============================================
- Coverage     81.29%   74.05%   -7.25%     
+ Complexity     2343     2119     -224     
============================================
  Files           264      264              
  Lines          7663     7663              
  Branches        790      790              
============================================
- Hits           6230     5675     -555     
- Misses         1097     1620     +523     
- Partials        336      368      +32
Flag Coverage Δ Complexity Δ
#integration ? ?
#unittests 74.05% <ø> (ø) 2119.00 <ø> (ø)
Impacted Files Coverage Δ Complexity Δ
...gcp/secretmanager/SecretManagerPropertySource.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-4.00%)
...a/spanner/repository/query/SpannerQueryMethod.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-6.00%)
...retmanager/SecretManagerPropertySourceLocator.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...figure/config/GcpConfigBootstrapConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...e/spanner/GcpSpannerEmulatorAutoConfiguration.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-2.00%)
...epository/config/SpannerRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...ository/config/DatastoreRepositoriesRegistrar.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-3.00%)
...restore/GcpFirestoreEmulatorAutoConfiguration.java 0.00% <0.00%> (-84.85%) 0.00% <0.00%> (-4.00%)
...ramework/cloud/gcp/vision/DocumentOcrTemplate.java 17.64% <0.00%> (-73.53%) 4.00% <0.00%> (-5.00%)
...work/cloud/gcp/bigquery/core/BigQueryTemplate.java 0.00% <0.00%> (-71.70%) 0.00% <0.00%> (-8.00%)
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45d4be...5ca23eb. Read the comment docs.

meltsufin
meltsufin approved these changes Jul 8, 2020
View reviewed changes
Copy link
Contributor

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eddumelendez Thanks for another awesome contribution to the project!
Complete with an integration test!
It looks good to me, but I'll let @elefeint do a more detailed review since she's focusing on the metrics support.

@eddumelendez eddumelendez mentioned this pull request Jul 9, 2020
Open
elefeint
elefeint suggested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Eddu, thank you -- the sample is great. I have a concern about the test, though -- see in comments.

...spring-cloud-gcp-metrics-sample/src/test/java/com/example/MetricsSampleApplicationTests.java Outdated Show resolved Hide resolved
...spring-cloud-gcp-metrics-sample/src/test/java/com/example/MetricsSampleApplicationTests.java Show resolved Hide resolved
...cloud-gcp-samples/spring-cloud-gcp-metrics-sample/src/main/java/com/example/Application.java Outdated Show resolved Hide resolved
...gcp-samples/spring-cloud-gcp-metrics-sample/src/main/java/com/example/ExampleController.java Outdated Show resolved Hide resolved
...spring-cloud-gcp-metrics-sample/src/test/java/com/example/MetricsSampleApplicationTests.java Show resolved Hide resolved
@eddumelendez
Copy link
Contributor Author

@elefeint thanks for the feedback! really good points. I have made the changes so test can reproduce every time without trusting in previous executions.

elefeint
elefeint suggested changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay -- there are a couple small issues that cropped up, otherwise looks good.

...spring-cloud-gcp-metrics-sample/src/test/java/com/example/MetricsSampleApplicationTests.java Outdated Show resolved Hide resolved
...spring-cloud-gcp-metrics-sample/src/test/java/com/example/MetricsSampleApplicationTests.java Outdated Show resolved Hide resolved
@eddumelendez
Copy link
Contributor Author

@elefeint PR updated. I got it wrong the previous time. Now, the test will hit just once the endpoint and will look for the metrics every 5 seconds in a lifetime of 4 minutes. Thanks for the feedback!

elefeint
elefeint approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@elefeint elefeint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help!

@elefeint elefeint merged commit a45057c into spring-attic:master Jul 14, 2020
@elefeint elefeint mentioned this pull request Jul 15, 2020
Closed
@meltsufin meltsufin mentioned this pull request Aug 11, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@meltsufin meltsufin meltsufin approved these changes

@elefeint elefeint elefeint approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eddumelendez @meltsufin @elefeint