-
Notifications
You must be signed in to change notification settings - Fork 692
Make all thread pools create daemon threads #2010
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2010 +/- ##
===========================================
- Coverage 80.37% 72.4% -7.98%
+ Complexity 2115 1879 -236
===========================================
Files 243 243
Lines 6895 6900 +5
Branches 709 709
===========================================
- Hits 5542 4996 -546
- Misses 1058 1576 +518
- Partials 295 328 +33
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* @since 1.2 | ||
*/ | ||
@RunWith(MockitoJUnitRunner.class) | ||
public class PubSubSubscriberTemplateTests { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't this part of some other PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
... and this is why it's a best practice to delete branches after merging to master ...
// shame cube
9a28cc3
to
3840092
Compare
Currently the thread pool for Pub/Sub's
SubscriberStub
keeps JVM from shutting down, causing non-web application to "hang".This PR makes all Spring Cloud GCP threads daemon threads that do not prevent a Spring application from stopping.
This is a change in behavior for Pub/Sub-dependent command line applications that subscribe to a Pub/Sub topic with
PubSubTemplate.subscribe()
, and expect the application to run until externally terminated.Fixes #2005.