From 22b5ca82e414bd89466b9217196645bfe6e54d8e Mon Sep 17 00:00:00 2001 From: Hao Xin Date: Fri, 4 Mar 2022 16:11:45 +0800 Subject: [PATCH 1/2] chore: fix comments --- controllers/flinkcluster/flinkcluster_util.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/controllers/flinkcluster/flinkcluster_util.go b/controllers/flinkcluster/flinkcluster_util.go index bdc93c32..ad6bccec 100644 --- a/controllers/flinkcluster/flinkcluster_util.go +++ b/controllers/flinkcluster/flinkcluster_util.go @@ -92,7 +92,7 @@ func getFlinkAPIBaseURL(cluster *v1beta1.FlinkCluster) string { *cluster.Spec.JobManager.Ports.UI) } -// Gets JobManager ingress name +// Gets ConfigMap name func getConfigMapName(clusterName string) string { return clusterName + "-configmap" } From c932288cacfad9c34f413519ac5951036b592a08 Mon Sep 17 00:00:00 2001 From: Hao Xin Date: Mon, 7 Mar 2022 15:53:55 +0800 Subject: [PATCH 2/2] comments typo --- controllers/flinkcluster/flinkcluster_converter.go | 4 ++-- controllers/flinkcluster/flinkcluster_util.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/controllers/flinkcluster/flinkcluster_converter.go b/controllers/flinkcluster/flinkcluster_converter.go index 1563ae49..a7471017 100644 --- a/controllers/flinkcluster/flinkcluster_converter.go +++ b/controllers/flinkcluster/flinkcluster_converter.go @@ -843,7 +843,7 @@ func appendEnvVars(envVars []corev1.EnvVar, newEnvVars ...corev1.EnvVar) []corev return envVars } -// Copy any non-duplicate volume mounts and env vars to the specified containers +// Copy any non-duplicate volume mounts and env vars to each specified container func convertContainer(container corev1.Container, volumeMounts []corev1.VolumeMount, envVars []corev1.EnvVar) corev1.Container { container.VolumeMounts = appendVolumeMounts(container.VolumeMounts, volumeMounts...) container.Env = appendEnvVars(container.Env, envVars...) @@ -851,7 +851,7 @@ func convertContainer(container corev1.Container, volumeMounts []corev1.VolumeMo return container } -// Copy any non-duplicate volume mounts and env vars to each specified container +// Copy any non-duplicate volume mounts and env vars to the specified containers func convertContainers(containers []corev1.Container, volumeMounts []corev1.VolumeMount, envVars []corev1.EnvVar) []corev1.Container { var updatedContainers = []corev1.Container{} for _, container := range containers { diff --git a/controllers/flinkcluster/flinkcluster_util.go b/controllers/flinkcluster/flinkcluster_util.go index ad6bccec..be5b9036 100644 --- a/controllers/flinkcluster/flinkcluster_util.go +++ b/controllers/flinkcluster/flinkcluster_util.go @@ -112,7 +112,7 @@ func getJobManagerIngressName(clusterName string) string { return clusterName + "-jobmanager" } -// Gets TaskManager name +// Gets TaskManager StatefulSet name func getTaskManagerStatefulSetName(clusterName string) string { return clusterName + "-taskmanager" }