feat: run java process from no-isolated workers #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Gradle 6.0, we can inject `ExecOperations` to `WorkAction` instance so we can run java process in worker thread. refs #416
|
#430 will fix the broken build. See https://github.blog/changelog/2021-01-21-github-actions-short-sha-deprecation/ for detail. |
|
Kudos, SonarCloud Quality Gate passed! |
ThrawnCA
approved these changes
Mar 4, 2021
|
🎉 This PR is included in version 4.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #416, run the java process as not Gradle worker but as an isolated process.
To avoid making the build process blocked, we run the process in a worker. From Gradle 6.0, we can inject
ExecOperationsto theWorkActioninstance so we can run a process in a worker thread (it was impossible because the worker cannot access aProjectinstance that provides#javaexec()method).This feature needs one consideration: If we launch a process by
ExecOperations#javaexec(), we cannot touch its stdout and stderr. So in case of failure, it could be difficult to identify the root cause. For now, I found no way to handle it, so I want to release this feature as disabled-by-default. After we confirmed that this feature really solves the issue, I will enable this feature by default.To reviewer:
Please squash-and-merge this PR with a commit message that has
feat:prefix, then it will release a minor update.