targets.docs.title config to render <title> #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dahlia
added
typ:enhance
kanghyojun
previously approved these changes
Mar 22, 2018
AiOO
reviewed
Mar 23, 2018
| [targets.python] | ||
| name = "nirum_fixture" | ||
| [targets.python.renames] | ||
| "renames.test" = "renamed" | ||
|
|
||
| [targets.docs] | ||
| title = "Fixtures for Nirum tests" |
Codecov Report
@@ Coverage Diff @@
## master #253 +/- ##
=========================================
+ Coverage 73.13% 75.3% +2.17%
=========================================
Files 33 33
Lines 2356 2361 +5
Branches 130 136 +6
=========================================
+ Hits 1723 1778 +55
+ Misses 503 447 -56
- Partials 130 136 +6
Continue to review full report at Codecov.
|
|
@admire93 @AiOO I rebased it on the current master, added some tests, and wrote docs about docs target. |
kanghyojun
previously approved these changes
Mar 25, 2018
kanghyojun
approved these changes
Mar 26, 2018
AiOO
approved these changes
Mar 27, 2018
dahlia
added a commit
that referenced
this pull request
Mar 27, 2018
targets.docs.title config to render <title>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to render a meaningful
<title>, a new required configurationtargets.docs.titlewas added.