Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

univ@stable 被写死为 0.1.5 了 #118

Closed
hotoo opened this issue Feb 13, 2015 · 6 comments
Closed

univ@stable 被写死为 0.1.5 了 #118

hotoo opened this issue Feb 13, 2015 · 6 comments
Assignees
Labels

Comments

@hotoo
Copy link
Member

hotoo commented Feb 13, 2015

  • 第一行命令看来貌似 stable 是正确的
  • 但是后续无论如何配置,univ@stable 都是 0.1.5
  • 删掉 cache 或者已安装的 spm_modules 都不行。
➜  webforms git:(develop) ✗ spm info univ

  univ
  0.2.2 ~ stable ~ 2015-02-09T14:10:14+00:00
  Universal Validator.
  author: 闲耘<[email protected]>
  versions: 0.2.2  0.2.1  0.2.0  0.1.7  0.1.6
            0.1.5  0.1.4  0.1.3  0.1.2  0.1.1
            0.1.0
  homepage: https://github.com/webforms/univ
  repository: [email protected]:webforms/univ.git

➜  webforms git:(develop) ✗ cat package.json| grep univ
      "univ": "~0.2.0" -- 不管这里是不写,还是写其他版本更高版本,都会被 save 改为 0.1.5
➜  webforms git:(develop) ✗ spm install univ

        install: univ@stable
          found: [email protected]

➜  webforms git:(develop) ✗ ll ~/.spm/cache/ | grep univ
-rw-r--r--  1 hotoo  staff   6.7K  1  9 21:12 univ-0.1.5.tar.gz
➜  webforms git:(develop) ✗ rm ~/.spm/cache/univ-0.1.5.tar.gz 
➜  webforms git:(develop) ✗ spm install univ --save

        install: univ@stable
          saved: in dependencies [email protected]
          found: [email protected]

➜  webforms git:(develop) ✗ ll ~/.spm/cache | grep univ
➜  webforms git:(develop) ✗ rm -rf spm_modules/univ/0.1.5 
➜  webforms git:(develop) ✗ spm install univ             

        install: univ@stable
       download: http://spmjs.io/repository/univ/0.1.5/univ-0.1.5.tar.gz
        extract: ~/.spm/cache/univ-0.1.5.tar.gz
      installed: $CWD/spm_modules/univ/0.1.5
        depends: [email protected], [email protected]
        install: [email protected]
          found: [email protected]
        install: [email protected]
          found: [email protected]

➜  webforms git:(develop) ✗ spm -v    
3.3.4
@sorrycc sorrycc self-assigned this Feb 13, 2015
@sorrycc sorrycc added the bug label Feb 13, 2015
@afc163
Copy link
Member

afc163 commented Feb 13, 2015

有两个问题。

  1. stable 是不是就不要走 tag 逻辑了?直接读外面的 version 就好?spm info univ 是没走 tag 逻辑的。
  2. https://github.com/spmjs/spm-client/blob/f102bac6ac012a2a1a33cab6191f74bf6ea7b8f3/lib/info.js#L52

这里的 sort 比较有问题,不知道为啥 0.1.5 比 0.2.0 还大,应该用 semver 版本比较。

@sorrycc
Copy link
Member

sorrycc commented Feb 13, 2015

stable 是不是就不要走 tag 逻辑了?直接读外面的 version 就好?spm info univ 是没走 tag 逻辑的。

这里说的是 install 的时候? 我把 info 里的 sort 改掉就都好了。

@sorrycc
Copy link
Member

sorrycc commented Feb 13, 2015

@hotoo bumped [email protected],重装下 spm 试试。

@hotoo
Copy link
Member Author

hotoo commented Feb 13, 2015

@stable 逻辑是在客户端处理的?怎么不是服务端的?

@sorrycc
Copy link
Member

sorrycc commented Feb 13, 2015

是的,客户端。没指定版本时,是从服务端拿所有版本的索引数据,然后本地分析取最新版信息。

@hotoo
Copy link
Member Author

hotoo commented Feb 13, 2015

好了。

做到服务端是不是更好点?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants