Problem with total spend

[gauthier12]

There is a problem with to total displayed in statistics.
If i understood correctly :
- If Alice buy something 20 for Alice and Bob
- Bob give her 10 for refund.
In theory, the total spend is 20 but ihatemoney will display 30 because the reimbursement is considered as an expense. The total will always be 1.5 * real value.
We should be able to "tag" the reimbursement in order not to take it into account in the total.

[dnshnrch]

Was on holidays recently and stumbled over this issue as well. When looking into the statistics in my connected cospend instance within nextcloud, the reimbursement (provided the expense is tagged correctly) is considered correctly as your simple example shows.

[almet]

Thanks for reporting this. Don't hesitate to propose a solution and open a pull request if you feel like it :-)

[gauthier12]

@dnshnrch I don't understand if you are agreeing with me about the problem or if I missed something to "tag" the refund

[dnshnrch]

@gauthier12 : I think we agree on the problem. In my case, when setting up a new project in Cospend (app within a nextcloud instance), there is a preconfigured category named "Erstattung" (engl.: 'Reimbursement'). Bobs reimbursement of 10 needs to be tagged accodingly and cospend will get the statistics right. The total amount of spent money should stay at 20 (which is, what Alice paid).
But in MoneyBuster (AndroidApp for Cospend and ihatemoney) the total amount is 30. I added some screenshots to show the problem.

Writing this, I hope the problem is clear, despite the fact, that this is maybe not directly ihatemoney related? I don't now whether moneybuster and ihatemoney share the same code basis.

@almet : Sorry, I'm only a user and not a programmer. I'm not able to lend a hand here :/

Expected behaviour:

Wrong behaviour:

[gauthier12]

I have possible ideas for a solution but I am not competent with Python to implement it.
The solution would be to add a bool flag "refund" or "internal movement" and not take the expense into account in the sum if the the flag is set to true.
I realized that in triccount, there is this kind of flags : https://www.tricount.com/en/difference-expense-money-transfer-income
with additional informations of expense/income/transfert

[ixcheldelsun]

Hi, first time contributing to open source but I have DS and backend background to check this out. Still open?

[pH142857]

Hi, first time contributing to open source but I have DS and backend background to check this out. Still open?

Hi, I think it's still open, feel free to submit a PR :) (disclaimer, I'm not part of the project)

[kellikuramoto]

My team would like to work on this issue! We are from CMU and contributing to an open source project is part of a class assignment.

[mvkashyap]

Hi! I'm with @kellikuramoto 's group. We are considering adding a button on the Settle page so that the reimbursement doesn't affect the total spent. In other words, the bill will be settled on the settle page, and it won't show up on the bills tab, but it also will not contribute to the total spent.

[gauthier12]

Hi.
Will you plan to do a "partial settle" e.g. I reimburse only a part or I lend money to someone?
How will you store the information that the transaction is a reimbursement ?
Cheers
Gauthier

[mvkashyap]

@gauthier12 we are including a "type" of bill that is marked as a reimbursement. This type of bill would help settle other bills without adding to the total spent.

[Glandos]

This is somewhat duplicate of #137

[zorun]

Closing because #1290 has been merged