-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MQTT trigger and tests #175
Add MQTT trigger and tests #175
Conversation
Signed-off-by: Kate Goldenring <[email protected]>
@Mossaka have you seen these build errors before? |
Looks like it's failing trying to find OpenSSL:
|
@devigned yeah it has to do with how the |
we had similar issue in Spin when adding MQTT support, and static builds were fixed using this PR: https://github.com/fermyon/spin/pull/2307/files could we please see if that fix helps in this case here. unfortunately the CI logs for that PR are gone, so can't really verify the exact error msg. |
Signed-off-by: Kate Goldenring <[email protected]>
@rajatjindal thank you! that got me past the build errors. |
Signed-off-by: Kate Goldenring <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
…ut for tests Signed-off-by: Kate Goldenring <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once CI is happy, LGTM.
Thank you!
Signed-off-by: Kate Goldenring <[email protected]>
8e2d2ea
to
3ee6dfc
Compare
Signed-off-by: Kate Goldenring <[email protected]>
9adae4e
to
488eecb
Compare
After many iterations on the e2e test configuration we are all green 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
closes #111
This should be merged first and then ideally a release of the trigger cut: spinframework/spin-trigger-mqtt#29
Adds an MQTT test which contains a deployment for an MQTT broker and a spin app that is triggered by the the broker.