Make container environment variables accessible as application variables #149
Conversation
kate-goldenring
changed the title
kate-goldenring
force-pushed
the
runtime-and-app-env-config
branch
from
2a32c71 to
ce35a35
Compare
kate-goldenring
force-pushed
the
runtime-and-app-env-config
branch
from
02ff7fb to
5d8868a
Compare
|
I updated the implementation to check the |
kate-goldenring
requested review from
jsturtevant,
radu-matei and
devigned
as code owners
| @@ -43,6 +43,9 @@ const OCI_LAYER_MEDIA_TYPE_WASM: &str = "application/vnd.wasm.content.layer.v1+w | |||
| /// Expected location of the Spin manifest when loading from a file rather than | |||
| /// an OCI image | |||
| const SPIN_MANIFEST_FILE_PATH: &str = "/spin.toml"; | |||
| /// Known prefix for the Spin application variables environment variable | |||
| /// provider: https://github.com/fermyon/spin/blob/436ad589237c02f7aa4693e984132808fd80b863/crates/variables/src/provider/env.rs#L9 | |||
| const SPIN_APPLICATION_VARIABLE_PREFIX: &str = "SPIN_VARIABLE"; | |||
There was a problem hiding this comment.
Follow-up perhaps: Update https://github.com/fermyon/spin/blob/436ad589237c02f7aa4693e984132808fd80b863/crates/variables/src/provider/env.rs#L9 to pub and use directly here?
There was a problem hiding this comment.
I am not sure it is worth bringing in the variables crate for this constant (if we did make it pub). Maybe with the spin factors work, this will be more directly configured by the shim
kate-goldenring
force-pushed
the
runtime-and-app-env-config
branch
from
5d8868a to
4554a80
Compare
- Sets any non-execution environment variables in the Spin app unless a disable env var is set Signed-off-by: Kate Goldenring <[email protected]>
…s application variables Signed-off-by: Kate Goldenring <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
Signed-off-by: Kate Goldenring <[email protected]>
kate-goldenring
force-pushed
the
runtime-and-app-env-config
branch
from
4554a80 to
40fa6df
Compare
|
Just rebased. @Mossaka @jsturtevant @devigned @radu-matei this is ready to review. |
Prefixes all container env vars with
SPIN_VARIABLE. This means that Spin components can get access to these variables if specifically configured in the Spin manifest to have access. For example, say a a component wants access to theKUBERNETES_SERVICE_ADDRESScontainer environment variable, it would configure this in the Spin.toml as follows:[variables] kubernetes_service_address = { required = true } [component.example] source = "target/wasm32-wasi/release/example.wasm" allowed_outbound_hosts = [] [component.example.variables] kubernetes_service_address = "{{ kubernetes_service_address }}"Then, it can be accessed in the Spin app using the variables SDK:
Should affect/reflect the "Configuring Runtime Options" SKIP spinframework/skips#4